Improve naming and delete unnecessary Mode
#1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't expect us to have more modes, hence a simple boolean value should be enough for indicating the mode of the teamplate. Apart from that, the name "inverted" woudln't always make sense, because if you invert something that is inverted, it gets back to its original mode. This commit will remove the `Mode` enum, and also improve the naming of some methods in the `Result`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1526 +/- ##
=========================================
Coverage 96.66% 96.66%
+ Complexity 1020 1019 -1
=========================================
Files 206 206
Lines 2548 2551 +3
=========================================
+ Hits 2463 2466 +3
Misses 85 85 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't expect us to have more modes, hence a simple boolean value should be enough for indicating the mode of the teamplate. Apart from that, the name "inverted" woudln't always make sense, because if you invert something that is inverted, it gets back to its original mode.
This commit will remove the
Modeenum, and also improve the naming of some methods in theResult.