feat: updates to video review GUI #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- clicking on a yet-to-be-downloaded video moves it to the top of the queue so it is downloaded next - make sure the download thread sleeps when it's done (d'oh!) - add a "status" column, later changes will download by default in low res and offer the option to use higher res
Add status column with icons to indicate download status
- re-download file if it exists but filesize doesn't match expected value - use a QTreeWidget instead of a QTableWidget in order to present channel 1 as a child of channel 0 (you never want to watch channel 1 without having established that channel 0 had something interesting) - add CLI --sub to search the sub stream (faster downloads = faster review) - the new logic also presents sub & main in the same tree root (conceptually, one start datetime = tree root under which all video related to that moment are listed) - add icons for statuses - exit after 1second timeout instead of being blocked until end of download
Benehiko
approved these changes
Oct 8, 2024
Benehiko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My commit history is super ugly because I made 0 effort to clean it up due to the fast iteration going on at the moment.
Let me know what you'd rather see - what I cannot promise is super well written hyper detailed commit messages, but I can certainly squash and summarize?
I do not expect this to go on for long - this is nearly done wrt the basics I require for my own use case, later development will happen based on community feedback if any.
tl;dr Lots of small quality of life updates to the app.