missing https certificate throws exception

[GsDublin]

With https function throws:
SSLError("bad handshake: Error([('SSL routines', 'tls_process_server_certificate',...

[Benehiko]

Hi @GsDublin
Thank you for your contribution :)

I think we need to have the default set to True and allow people to pass down the value when opening a stream.

[GsDublin]

Hello @Benehiko,
Iam a new git member and iam trying to use this tool in both directions ;-)

I think it should be a global parameter.
Im sure the problem would be at each call, of each .get function.
Should i try to do the changes, and you check my modifications like this?

Some people deactivated the https, some people use only https, and someone uses own certificates?

Iam using following cams:
E1 Zoom, RLC-810A, RLC-511, RLC-410-5MP, RLC-810A (IPC_523128M8MP) and RLC-820A (IPC_523128M8MP)

For the "new" one (e.g. RLC-810A, RLC-820A) we need to add a new API command: GetRecV20, GetFtpV20, GetPushV20.

[Benehiko]

HI @GsDublin no worries :)

You can use the kwargs param from here https://github.com/ReolinkCameraAPI/reolinkapipy/blob/master/reolinkapi/camera.py#L6-L12

and pass along an expected value for verifying ssl and if it is true check for passed down ssl certificates
like we do here

reolinkapipy/reolinkapi/handlers/api_handler.py

Line 58 in 8b6049b

Request.proxies = kwargs.get("proxy") # Defaults to None if key isn't found

then you can call it through the classself. property like we do here

reolinkapipy/reolinkapi/mixins/stream.py

Line 26 in 8b6049b

ip=self.ip, username=self.username, password=self.password, profile=self.profile, proxies=proxies, callback=callback)

For the other API functions I would recommend opening separate PRs so it is easier to keep track of changes :)

[Benehiko]

Hi @GsDublin any update on this?

[Vaelatern]

I'm expecting I'll pick this up just to clean up my log files while I'm using this (with the changes to pass it down).

[Vaelatern]

@Benehiko have a look at this commit? Vaelatern@8cf5f7f
I decided not to proceed with it, but it might be useful