Skip to content

Commit

Permalink
Bump to ISPC v1.25.0 (new minimum required version)
Browse files Browse the repository at this point in the history
  • Loading branch information
johguenther committed Oct 16, 2024
1 parent 675c216 commit bbae73c
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 18 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ Version History
improving compatibility with glTF `KHR_materials_specular`
- Improvements to and documentation of the pathtracer's Shadow Catcher
feature (enabled via parameter `shadowCatcherPlane`)
- The new minimum versions of dependencies:
- ISPCRT v1.25.0 (uses IEEE 754 compliant instructions on ARM for
min/max)

### Changes in v3.2.0:

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ before you can build OSPRay you need the following prerequisites:
Linux development tools.

- Additionally you require a copy of the [Intel® Implicit SPMD Program
Compiler (ISPC)](http://ispc.github.io), version 1.23.0 or later.
Compiler (ISPC)](http://ispc.github.io), version 1.25.0 or later.
Please obtain a release of ISPC from the [ISPC downloads
page](https://ispc.github.io/downloads.html). If ISPC is not found by
CMake its location can be hinted with the variable `ISPC_EXECUTABLE`.
Expand Down
2 changes: 1 addition & 1 deletion cmake/ospray_options.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ include(CMakeDependentOption)
set(OSPRAY_CMAKECONFIG_DIR
"${CMAKE_INSTALL_LIBDIR}/cmake/ospray-${OSPRAY_VERSION}")

set(ISPC_VERSION_REQUIRED 1.23.0)
set(ISPC_VERSION_REQUIRED 1.25.0)
set(RKCOMMON_VERSION_REQUIRED 1.14.2)
set(EMBREE_VERSION_REQUIRED 4.3.3)
set(OPENVKL_VERSION_REQUIRED 2.0.1)
Expand Down
2 changes: 1 addition & 1 deletion doc/prerequisites.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ before you can build OSPRay you need the following prerequisites:
(icc)](https://software.intel.com/en-us/c-compilers)), and standard
Linux development tools.
- Additionally you require a copy of the [Intel® Implicit SPMD Program
Compiler (ISPC)](http://ispc.github.io), version 1.23.0 or later.
Compiler (ISPC)](http://ispc.github.io), version 1.25.0 or later.
Please obtain a release of ISPC from the [ISPC downloads
page](https://ispc.github.io/downloads.html).
If ISPC is not found by CMake its location can be hinted with the
Expand Down
14 changes: 7 additions & 7 deletions scripts/superbuild/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -87,22 +87,22 @@ endif()

option(DOWNLOAD_ISPC "Download ISPC or use the one found in the system environment?" ON)
if (DOWNLOAD_ISPC)
set(ISPC_VERSION "1.24.0" CACHE STRING "Which version of ISPC to download?")
set(ISPC_VERSION "1.25.0" CACHE STRING "Which version of ISPC to download?")
mark_as_advanced(CLEAR ISPC_VERSION)
if (ISPC_VERSION STREQUAL "1.24.0")
if (ISPC_VERSION STREQUAL "1.25.0")
if (APPLE)
if (${CMAKE_SYSTEM_PROCESSOR} MATCHES "arm64|aarch64")
set(ISPC_HASH "7f3891d0157aed3cab159fbc5235235b62797053db9387f5a61c8d0a22369ae0")
set(ISPC_HASH "1d4474c65579e635cc2f45b87e779d4d821b5eac3b1f02ffe2a7529a29de436f")
else()
set(ISPC_HASH "986eb172fe9db3e8da560e9d0d788832991638fab61ca80587d87eb175ffb520")
set(ISPC_HASH "9097f02a95e68198ce41b9ca59cae6944f3df68e11987d1b86a041a55d720705")
endif()
elseif (WIN32)
set(ISPC_HASH "a7c21cb2434f5364acbdf0933af6de49198458ed6f0b62012e03c3325c972649")
set(ISPC_HASH "a31987fd17f7435ca7ff1f7d7b8979a6972be9e8c6d391245b6b71c42c32d541")
else()
if (${CMAKE_SYSTEM_PROCESSOR} MATCHES "arm64|aarch64")
set(ISPC_HASH "890ad5f31581091bf4ae9f235a7bb6fd9cabcbd6cf1670104ad61f1ad2da4c76")
set(ISPC_HASH "aea63d105ad854d2130a24a4763bcf5b90cc448880de6479466f2ed7a5444f52")
else()
set(ISPC_HASH "79885d4482356dba7c01da312b6449fd575b097845ebcb90344dac5c178b43f5")
set(ISPC_HASH "c503dfc26ecfbc4e322c07ca4aae1c2c81b3c4cf1e556ab4d69856f936e08631")
endif()
endif()
endif()
Expand Down
8 changes: 0 additions & 8 deletions scripts/tests/run_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,6 @@ export CMAKE_BUILD_PARALLEL_LEVEL=32
cmake --build . --target ospray_test_data
let exitCode+=$?

### Excluded tests
##################
# due to IEEE 754 uncompliant NaN handling on ARM NEON,
# see https://github.com/ispc/ispc/issues/3048
if [[ `uname -m` =~ arm|aarch ]] ; then
test_filters="TestShadowCatcher/ShadowCatcher.multipleLights/0"
fi

export OIDN_VERBOSE=2

if [ $TEST_CPU ]; then
Expand Down

0 comments on commit bbae73c

Please sign in to comment.