Fixed issue in option page that allowed login on unsaved configurations

RemiRigal · Oct 13, 2021 · 54e145b · 54e145b
1 parent b11c45d
commit 54e145b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/manifest.json b/manifest.json
@@ -1,6 +1,6 @@
 {
   "name": "Yape",
-  "version": "0.0.5",
+  "version": "0.0.6",
   "description": "Extension for PyLoad to easily monitor and add downloads",
   "permissions": ["activeTab", "storage", "contextMenus", "scripting"],
   "host_permissions": ["http://*/", "https://*/"],

diff --git a/options.js b/options.js
@@ -45,7 +45,7 @@ function getProtocol() {
     return useHTTPSInput.checked ? 'https' : 'http';
 }
 
-function updateLoggedInStatus() {
+function updateLoggedInStatus(callback) {
     saveButton.disabled = true;
     loginStatusOKDiv.hidden = true;
     loginStatusKODiv.hidden = true;
@@ -57,6 +57,7 @@ function updateLoggedInStatus() {
         loginStatusKODiv.hidden = loggedIn;
         loginButton.hidden = loggedIn;
         saveButton.disabled = false;
+        if (callback) callback();
     });
 }
 
@@ -81,6 +82,17 @@ function requestPermission(callback) {
     });
 }
 
+function requireSaving() {
+    if (serverIpInput.value === serverIp && parseInt(serverPortInput.value) === parseInt(serverPort) && useHTTPSInput.checked === (serverProtocol === 'https')) {
+        updateLoggedInStatus();
+    } else {
+        saveButton.disabled = false;
+        loginStatusOKDiv.hidden = true;
+        loginStatusKODiv.hidden = true;
+        loginButton.hidden = true;
+    }
+}
+
 saveButton.onclick = function(ev) {
     setOrigin(serverIpInput.value, serverPortInput.value, getProtocol(), function() {
         requestPermission(function(granted) {
@@ -110,5 +122,9 @@ pullStoredData(function() {
     serverPortInput.value = serverPort;
     useHTTPSInput.checked = serverProtocol === 'https';
 
+    serverIpInput.oninput = requireSaving;
+    serverPortInput.oninput = requireSaving;
+    useHTTPSInput.oninput = requireSaving;
+
     updateLoggedInStatus();
 });