Skip to content

Commit

Permalink
Bump Verison to 1.25.10
Browse files Browse the repository at this point in the history
  • Loading branch information
Sewer56 committed Feb 28, 2024
1 parent 195a913 commit 31115d1
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 10 deletions.
29 changes: 21 additions & 8 deletions changelog-template.hbs
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
## Changelog (1.25.9) | Defender Mitigation
## Changelog (1.25.10) | Misc Hotfixes

This release is dedicated to Windows Defender. I'll try to keep it short.
- Fixed bug introduced in last update 32-bit Reloaded Launcher (`Reloaded-II32.exe`) couldn't DLL inject on 64-bit operating systems.
- Slightly redesigned settings menu, to better expose language selection.

Also thanks to @Sencaid for German Translation, I missed that in last changelog >w<
Expect more minor bugfixes over weekend, this is just all I can do after work hours so far this week.

## Defender Mitigation Announcement | Changelog (1.25.9)

This release (1.25.9) is dedicated to Windows Defender. I'll try to keep it short.

In the past week alone, ***I've seen over 300 reports*** of false positive virus detections
affecting users. At peak, around ***4 issue reports an hour***.
Expand All @@ -12,12 +20,15 @@ This was not easy for anyone. I respond to all issues, usually within 10 minutes
Likewise, volunteers in game specific modding servers also take their time out of their day to help
troubleshoot users' issues. It was a heavy burden on everyone.

### This was Rough

As this coincided with 2 game releases, where people starting Reloaded, the timing could not have been
any more unfortunate. Many new users had to experience an absolute trainwreck of a first impression;
whether it be due to defender, some longstanding rare bugs, or silent antivirus treatment.

Worseover, I could not even fix these bugs. Because the virus detections were made by the 'machine learning'
side of Defender, releasing ***ANY UPDATE AT ALL*** means that 1000s of users would get new false positives.
[Dolphin Emulator was in the same predicament a few years ago](https://dolphin-emu.org/blog/2019/11/07/dolphin-progress-report-october-2019/#windows-defender-yelling-at-a-cloud-ai).

This was a result of the releases not being 'deterministic', the files in each Reloaded build/version
would change, even if the code didn't, and Defender would flag it. Reporting a false positive therefore
Expand All @@ -29,7 +40,7 @@ of my bed getting this resolved.

-----
So here's what's up:
# So what's been done so far to mitigate this issue?
## Replaced DLL Injection logic
Expand Down Expand Up @@ -58,9 +69,10 @@ the actual files in the releases won't change.
This hopefully means that if a file gets a false positive virus detection, releasing an update won't
cause it to be flagged again.
### Download Loops
## Download Loops
[Note] Historically this has been a very rare occurrence, but has been sighted more commonly recently.
> [!NOTE]
> Historically this has been a very rare occurrence, but has been sighted more commonly recently.
Some people get stuck downloading dependencies. This usually manifests itself as a download window
appearing and disappearing endlessly on loop.
Expand All @@ -71,7 +83,7 @@ inform you what it's failing to download, and ask you to install manually.
It's a very awful hack, but it's the best I can do for now. I could never reproduce this issue myself,
so fixing it is a shot in the dark. I'll eventually need to borrow someone inflicted by this bug.
----------------
# That's All
In the future, say, with Reloaded3, I may invest in code signing certificate (i.e. legal form of
extortion to avoid false positives), but for now, I'm doing what I can.
Expand All @@ -81,8 +93,9 @@ I'm sorry for the inconvenience caused, and I want to thank all the volunteers w
I'm aware some other issues are still present, I hope to get to them soon. However, I'm just a single
person, and there's only so much I can do...
(Note: Most big modding frameworks/loaders/managers are maintained by teams of people.
Unfortunately, I'm not that fortunate, it's all done solo here.)
> [!NOTE]
> Most big modding frameworks/loaders/managers are maintained by teams of people. Unfortunately, I'm not that fortunate, it's all done solo here.
## Complete Changes
Expand Down
2 changes: 1 addition & 1 deletion source/Reloaded.Mod.Launcher/Reloaded.Mod.Launcher.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<UseWPF>true</UseWPF>
<AssemblyName>Reloaded-II</AssemblyName>
<RootNamespace>Reloaded.Mod.Launcher</RootNamespace>
<Version>1.25.9</Version>
<Version>1.25.10</Version>
<Copyright>Sewer56 ~ $([System.DateTime]::UtcNow.ToString("s")) | $(Version)</Copyright>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
<ApplicationIcon>appicon.ico</ApplicationIcon>
Expand Down
2 changes: 1 addition & 1 deletion source/Reloaded.Mod.Loader/Reloaded.Mod.Loader.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
<NoWarn>$(NoWarn);NU1605;NU1701</NoWarn>
<Version>1.25.9</Version>
<Version>1.25.10</Version>
<Platforms>x86;x64</Platforms>
<GenerateDepsJson>false</GenerateDepsJson>
<DebugType>portable</DebugType>
Expand Down

0 comments on commit 31115d1

Please sign in to comment.