[Dates] Make test more robust against non-UTC timezones (#55829) #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) `%M` is the format specifier for the minutes, not the month (which should be `%m`), and it was used twice. Also, on macOS `Libc.strptime` internally calls `mktime` which depends on the local timezone. We now temporarily set `TZ=UTC` to avoid depending on the local timezone. Fix JuliaLang#55827.
github-actions
bot
added
port-to-v1.10
d-netto
removed
the
port-to-master
kpamnany
approved these changes
Sep 23, 2024
d-netto
added a commit
that referenced
this pull request
Sep 25, 2024
…aLang#55829) (#184)" This reverts commit a911d00.
kpamnany
pushed a commit
that referenced
this pull request
Sep 25, 2024
…aLang#55829) (#184)" (#188) This reverts commit a911d00.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
One more PR to make JuliaLang CI in our fork a bit more stable.
Checklist
Requirements for merging:
port-to-*labels that don't apply.