Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct GC bug (usage of not_freed_enough) #129

Closed
wants to merge 1 commit into from

Conversation

kpamnany
Copy link
Collaborator

@kpamnany kpamnany commented Feb 13, 2024

PR Description

Fix a typo-bug in the GC.

Checklist

Requirements for merging:

@github-actions github-actions bot added port-to-v1.10 This change should apply to Julia v1.10 builds port-to-master This change should apply to all future Julia builds port-to-v1.9 This change should apply to Julia v1.9 builds labels Feb 13, 2024
@kpamnany kpamnany removed port-to-master This change should apply to all future Julia builds port-to-v1.9 This change should apply to Julia v1.9 builds labels Feb 13, 2024
Copy link
Member

@d-netto d-netto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM. Please confirm whether this doesn't have a negative impact in the benchmarks.

@kpamnany
Copy link
Collaborator Author

Since we're now on 1.10 and this bug doesn't exist there, I'm closing this.

@kpamnany kpamnany closed this Mar 19, 2024
@d-netto d-netto removed the port-to-v1.10 This change should apply to Julia v1.10 builds label May 6, 2024
@kpamnany kpamnany deleted the kp-fix-53325 branch August 26, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants