Skip to content

Commit

Permalink
docs: update contributing guide
Browse files Browse the repository at this point in the history
  • Loading branch information
Rel1cx committed Feb 2, 2025
1 parent bb15d1f commit b4c869e
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
8 changes: 4 additions & 4 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# ESLint React Contributing Guide

> [!NOTE]\
> FYI: The ESLint Raect project is not a fork of the `eslint-plugin-react` project and meanwhile `eslint-plugin-react` is not the upstream of ESLint React.\
> Therefore, the rules and features you see in `eslint-plugin-react` may not necessarily appear in ESLint React and its plugins.
Hi! We, the maintainers, are really excited that you are interested in contributing to ESLint React.

Before submitting your contribution though, please make sure to take a moment and read through the [Code of Conduct](CODE_OF_CONDUCT.md), as well as the appropriate section for the contribution you intend to make:
Expand All @@ -10,10 +14,6 @@ Before submitting your contribution though, please make sure to take a moment an
- [Development Guide](#development-guide)
- [Packages Overview](#packages-overview)

> [!NOTE]\
> FYI: The ESLint Raect project is not a fork of the `eslint-plugin-react` project and meanwhile `eslint-plugin-react` is not the upstream of ESLint React.\
> Therefore, the rules and features you see in `eslint-plugin-react` may not necessarily appear in ESLint React and its plugins.
## Issue Reporting Guidelines

- The issue list of this repo is **exclusively** for bug reports and feature requests. Non-conforming issues will be closed immediately.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,9 @@ function getName(node: TSESTree.Expression | TSESTree.PrivateIdentifier): string
function isAssignmentToThisState(node: TSESTree.AssignmentExpression) {
const { left } = node;

return (
left.type === T.MemberExpression
return left.type === T.MemberExpression
&& AST.isThisExpression(left.object)
&& getName(left.property) === "state"
);
&& getName(left.property) === "state";
}

export default createRule<[], MessageID>({
Expand Down

0 comments on commit b4c869e

Please sign in to comment.