handle hr and log for missing handler

src/rer/newsletter/blocks_converter/__init__.py

@@ -22,7 +22,9 @@ def __call__(self, context, blocks, blocks_layout):
             return ""
         html = []
         for block in blocks:
-            handler = getattr(self, f"block_handler_{block.get('@type', '')}", None)
+            handler = getattr(
+                self, f"block_handler_{block.get('@type', '')}", None
+            )
             if handler and callable(handler):
                 value = handler(context=context, block=block)
                 if value:
@@ -64,9 +66,11 @@ def block_handler_image(self, block, context=None):
         Return converted image block to HTML
         """
         scales_mapping = {"l": "large", "s": "mini", "m": "preview"}
-        image_scales = block.get("image_scales", {}).get("image", [])[0]
+        image_scales = block.get("image_scales", {}).get("image", [])
         if not image_scales:
             return ""
+
+        image_scales = image_scales[0]
         align = block.get("align", "")
         root_classes = ["block", "image"]
 
@@ -110,7 +114,9 @@ def block_handler_gridBlock(self, block, context):
         tr = root.findAll("tr")[0]
 
         for block in blocks:
-            handler = getattr(self, f"block_handler_{block.get('@type', '')}", None)
+            handler = getattr(
+                self, f"block_handler_{block.get('@type', '')}", None
+            )
             if handler and callable(handler):
                 value = handler(block)
                 if value:

src/rer/newsletter/blocks_converter/slate2html.py

@@ -5,7 +5,9 @@
 from lxml.html import tostring
 
 import json
+import logging
 
+logger = logging.getLogger(__name__)
 
 SLATE_ACCEPTED_TAGS = ACCEPTED_TAGS + ["link"]
 
@@ -47,6 +49,9 @@ def serialize(self, element):
             handler = getattr(self, "handle_tag_{}".format(tagname), None)
             if not handler and tagname in SLATE_ACCEPTED_TAGS:
                 handler = self.handle_block
+        if not handler:
+            logger.warning(f"Unhandled tag: {tagname}. Skipping.")
+            return []
         res = handler(element)
         if isinstance(res, list):
             return res
@@ -87,6 +92,9 @@ def handle_slate_data_element(self, element):
 
         return el(*children, **attributes)
 
+    def handle_tag_hr(self, element):
+        return getattr(E, "HR")()
+
     def handle_block(self, element):
         """handle_block.