Test missing methods #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## region-pallet #93 +/- ##
==================================================
+ Coverage 64.05% 76.47% +12.41%
==================================================
Files 7 7
Lines 153 153
==================================================
+ Hits 98 117 +19
+ Misses 55 36 -19 ☔ View full report in Codecov by Sentry. |
Szegoo
approved these changes
Apr 23, 2024
Szegoo
added a commit
that referenced
this pull request
Apr 24, 2024
* Region pallet * progress * tests compiling * rename * make request * getting storage key works * progress * messy solution * improvements * improved solution * move types & on_timeout * runtime implementation progress * compiles * compiles * warnings * fix runtime * height provider * resolve some todos * init tests * setting record test * add todos * rename request status * correct logic * refactor * fix tests * mock improvements * clippy fixes * fix on_timeout * util read_value * ismp custom error * on_accept sanity test * merge * move primitives * merge * fix * new tests * add license * some refactors * more refactor * fix typo * test: set_record * test transfer * test request_region_record * fix: request_region_record_works * remove test on_timeout_handles_get_only * update request_region_record_works * add events * cargo fmt * add more tests * fix events problem * check events * add utility pallet * cargo fmt * cargo fmt again * cargo fmt nightly * cargo fmt * Benchmarks (#85) * WIP: benchmarking * fix benchmarks * check events in benchmarks * cargo fmt --------- Co-authored-by: Sergej <[email protected]> * weights for pallet-regions (#87) * weights for pallet-regions * add header and template to weights --------- Co-authored-by: Sergej <[email protected]> * remove duplicate item * fmt * cargo fixes * rename to codec * region_id defensive * dependency fix * fmt * small fixes * Test missing methods (#93) * test owner * refactor * test method: attribute * test nonfungible transfer * cargo fmt * update test for on_timeout * WIP: tests for on_response * fix test for invalid id and record --------- Co-authored-by: Sergej <[email protected]> * cargo fmt * fix cargo.toml * pre merge improvements & additional tests --------- Co-authored-by: cuteolaf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.