Skip to content

Commit

Permalink
Added TODO comments for #53.
Browse files Browse the repository at this point in the history
  • Loading branch information
ReedClanton committed Apr 26, 2023
1 parent eeb383c commit 177c838
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
1 change: 1 addition & 0 deletions .github/workflows/testing-unit-output-util-constants.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ jobs:
uses: ./.github/actions/install-kcov-and-shellspec
- name: Running unit tests from a 'bash' shell (with code coverage) from ${{ github.workspace }}...
run: shellspec --no-fail-fast -p -s /bin/bash --kcov --kcov-options "--include-pattern=src/shell/functions/output/util/constants.sh --limits=99,100" ./spec/unit/output/util/constants_*
# TODO #53: Pipeline doesn't process --fail-low-coverage correctly.
## run: $HOME/.local/bin/shellspec --no-fail-fast -p -s /bin/bash --kcov --kcov-options "--include-pattern=src/shell/functions/output/util/constants.sh --limits=99,100" --fail-low-coverage ./spec/unit/output/util/constants_*
unit-test-ubuntu-dash-output-util-constants:
runs-on: ubuntu-20.04
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ jobs:
uses: ./.github/actions/install-kcov-and-shellspec
- name: Running unit tests from a 'bash' shell (with code coverage) from ${{ github.workspace }}...
run: shellspec --no-fail-fast -p -s /bin/bash --kcov --kcov-options "--include-pattern=src/shell/functions/output/util/createHeaderFooter.sh --limits=94,100" ./spec/unit/output/util/createHeaderFooter_*
## run: shellspec --no-fail-fast -p -s /bin/bash --kcov --kcov-options "--include-pattern=src/shell/functions/output/util/createHeaderFooter.sh --limits=96,100" --fail-low-coverage ./spec/unit/output/util/createHeaderFooter_*
# TODO #53: Pipeline doesn't process --fail-low-coverage correctly.
## run: shellspec --no-fail-fast -p -s /bin/bash --kcov --kcov-options "--include-pattern=src/shell/functions/output/util/createHeaderFooter.sh --limits=94,100" --fail-low-coverage ./spec/unit/output/util/createHeaderFooter_*
unit-test-ubuntu-dash-output-util-createHeaderFooter:
runs-on: ubuntu-20.04
steps:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/testing-unit-output.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ jobs:
uses: ./.github/actions/install-kcov-and-shellspec
- name: Running unit tests from a 'bash' shell (with code coverage) from ${{ github.workspace }}...
run: shellspec --no-fail-fast -p -s /bin/bash --kcov --kcov-options "--include-pattern=src/shell/functions/output/output.sh --limits=87,100" ./spec/unit/output/output_*
## run: shellspec --no-fail-fast -p -s /bin/bash --kcov --kcov-options "--include-pattern=src/shell/functions/output/output.sh --limits=83,100" --fail-low-coverage ./spec/unit/output/output_*
# TODO #53: Pipeline doesn't process --fail-low-coverage correctly.
## run: shellspec --no-fail-fast -p -s /bin/bash --kcov --kcov-options "--include-pattern=src/shell/functions/output/output.sh --limits=87,100" --fail-low-coverage ./spec/unit/output/output_*
unit-test-ubuntu-dash-output:
runs-on: ubuntu-20.04
steps:
Expand Down
3 changes: 2 additions & 1 deletion .shellspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@

# Default kcov (coverage) options
--kcov-options "--exclude-pattern=main.sh"
--fail-low-coverage
# TODO #53: Figure out why this option always causes pipeline to fail.
# --fail-low-coverage

0 comments on commit 177c838

Please sign in to comment.