Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding lectern-book-place flag, updating dependency to 1.19 PaperMC #2

Merged
merged 3 commits into from
Sep 21, 2022
Merged

adding lectern-book-place flag, updating dependency to 1.19 PaperMC #2

merged 3 commits into from
Sep 21, 2022

Conversation

RedstoneFuture
Copy link
Member

@RedstoneFuture RedstoneFuture commented Sep 12, 2022 •
edited
Loading

Creating workaround for EngineHub/WorldGuard#1950 with using of PaperMC methods to manually place a book on a lectern.

tested on my testserver (1.19.2 PaperMC)

Xaver106
Xaver106 reviewed Sep 14, 2022
View reviewed changes
Copy link
Member

@Xaver106 Xaver106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code cleanup
It is not necessary to cast already checked Objects. It can be done directly in the if statement

src/main/java/de/xaver106/redworldguardflags/listeners/LecternBookPlaceEvent.java Outdated Show resolved Hide resolved
src/main/java/de/xaver106/redworldguardflags/listeners/LecternBookPlaceEvent.java Outdated Show resolved Hide resolved
src/main/java/de/xaver106/redworldguardflags/listeners/LecternBookPlaceEvent.java Outdated Show resolved Hide resolved
src/main/java/de/xaver106/redworldguardflags/listeners/LecternBookPlaceEvent.java Outdated Show resolved Hide resolved
@Xaver106 Xaver106 self-requested a review September 14, 2022 18:05
@RedstoneFuture
Copy link
Member Author

RedstoneFuture commented Sep 20, 2022 •
edited
Loading

Tested Ingame and works fine. You can merge it, if the last commit was fine.

@Xaver106 Xaver106 merged commit f92a854 into RedstoneWorld:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xaver106 Xaver106 Awaiting requested review from Xaver106

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RedstoneFuture @Xaver106