Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extra whitespace after update notifier #1407

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

lornajane
Copy link
Contributor

What/Why/How?

We did a new release yesterday and I noticed that when I get the release banner, I also get slightly indented output from whichever command I was using.

Screenshots (optional)

Screenshot from 2024-01-24 15-46-35

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@lornajane lornajane requested a review from a team as a code owner January 24, 2024 15:49
Copy link

changeset-bot bot commented Jan 24, 2024

⚠️ No Changeset found

Latest commit: 1acd358

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 24, 2024

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.062 ± 0.032 1.031 1.121 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.065 ± 0.016 1.044 1.101 1.00 ± 0.03

Copy link
Contributor

github-actions bot commented Jan 24, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 76.1% 4306/5658
🟡 Branches 65.82% 2240/3403
🟡 Functions 68.74% 695/1011
🟡 Lines 76.31% 4049/5306

Test suite run success

699 tests passing in 100 suites.

Report generated by 🧪jest coverage report action from 1acd358

@tatomyr tatomyr force-pushed the fix-update-notifier-whitespace branch from 7da52ac to 20bfafd Compare January 31, 2024 18:16
@tatomyr
Copy link
Contributor

tatomyr commented Jan 31, 2024

Updated the MR. Here's the screenshot:

image

@IgorKarpiuk IgorKarpiuk force-pushed the fix-update-notifier-whitespace branch from 20bfafd to 1acd358 Compare February 1, 2024 14:53
@tatomyr tatomyr merged commit 7832121 into main Feb 1, 2024
29 checks passed
@tatomyr tatomyr deleted the fix-update-notifier-whitespace branch February 1, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants