Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace refs to components when splitting file #1381

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

IgorKarpiuk
Copy link
Contributor

@IgorKarpiuk IgorKarpiuk commented Jan 4, 2024

What/Why/How?

Replace $refs to components when splitting json files.

Reference

Fixes #1379

Testing

Tested locally with example from issue

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@IgorKarpiuk IgorKarpiuk requested a review from a team as a code owner January 4, 2024 14:35
Copy link

changeset-bot bot commented Jan 4, 2024

🦋 Changeset detected

Latest commit: 1075232

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/cli Patch
@redocly/openapi-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.055 ± 0.032 1.031 1.136 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.066 ± 0.023 1.036 1.120 1.01 ± 0.04

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75.8% 4100/5409
🟡 Branches 66.07% 2183/3304
🟡 Functions 68.14% 663/973
🟡 Lines 76% 3847/5062
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / index.ts
67.5% 57.94% 85.19% 71.14%

Test suite run success

671 tests passing in 94 suites.

Report generated by 🧪jest coverage report action from 1075232

@IgorKarpiuk IgorKarpiuk self-assigned this Jan 5, 2024
@IgorKarpiuk IgorKarpiuk marked this pull request as draft January 5, 2024 09:01
@IgorKarpiuk IgorKarpiuk force-pushed the fix/split-ref-to-components branch from c12f2b3 to 53ce88d Compare January 5, 2024 13:41
@IgorKarpiuk IgorKarpiuk marked this pull request as ready for review January 5, 2024 13:45
@tatomyr tatomyr requested a review from a team January 10, 2024 10:48
@tatomyr tatomyr force-pushed the fix/split-ref-to-components branch from f994bf1 to 3893bfe Compare January 10, 2024 12:58
@lornajane
Copy link
Contributor

If this solves #1379 then please use the Fixes #123 format in the issue description so that the issue will close when the pull request merges. I realise the feature won't be available until the next release, but otherwise we have old issues that we aren't sure if they are fixed or not.

Copy link
Contributor

@lornajane lornajane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog is good, do you need more review from me?

@tatomyr
Copy link
Contributor

tatomyr commented Jan 16, 2024

@lornajane No, nothing else. Thank you 🙂

@tatomyr tatomyr force-pushed the fix/split-ref-to-components branch from 3893bfe to 1075232 Compare January 16, 2024 14:23
@tatomyr tatomyr merged commit 4f410b5 into main Jan 16, 2024
29 checks passed
@tatomyr tatomyr deleted the fix/split-ref-to-components branch January 16, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't resolve $ref after splitting openapi.json
3 participants