chore: fix OasSchema types

[vladkens]

What/Why/How?

Fix wrong typing for Oas3_1Schema.

When using type in TypeScript instead of interface, need to omit all overridden fields first.

type A = { type: string }
type B = A & { type: string | string[] }
const b: B = { type: ["string", "number"] } // typescript say error here

// so it should be
type C = Omit<A, "type"> & { type: string | string[] }
const c: C = { type: ["string", "number"] } // no problem now

Reference

https://www.typescriptlang.org/play?ssl=7&ssc=62&pln=1&pc=1#code/C4TwDgpgBAglC8UDeVSQFxQM7AE4EsA7AcygF8AoNaAIQVigDJlVwJMcCSoAfbPIsQDaAXXIUAxgHtCOKACNMdRCmqYhAIk6CNAGigbCAVwC28iLg1iyUAPS3WkLBIJhg2AIYgoF3FNxQABYWEBQU9thSUPjuWIFSRgA2ACYKodRQAML0APImMQA8MPoa1BoAfEwsavxcpHzaJKLi0rLuEpjZKo7sUJqNxHoGxmYWVuR2DoRRYH7yiRAmUNMA7kA

Testing

Screenshots (optional)

Check yourself

• Code is linted
• Tested with redoc/reference-docs/workflows (internal)
• All new/updated code is covered with tests

Security

• Security impact of change has been considered
• Code follows company security practices and guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: bc00b32

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[tatomyr]

Thanks for pointing this out, @vladkens!

I'd suggest using interface instead. I'm unsure of the initial reason for using the type. Moreover, there are more properties to cover here: properties, additionalProperties, items, allOf &c. - all of them should also be Oas3_1Schema instead of Oas3Schema. Don't you mind tackling that as well?

[lornajane]

@tatomyr I see that you asked for further changes on this pull request. Can the existing changes be reviewed as they are, or do your requested updates also need to be included to make it useful?

[tatomyr]

@lornajane for me it makes sense to do everything in one MR. If @vladkens won't respond, I'll make a separate update instead of this one once I have time.

[vladkens]

Hi, @tatomyr. Didn't see the notification in time.

Fixed nested typing too and made Oas3_1Schema as interface. Also put the general properties for v3 & v3.1 in a separate internal interface.

Please re-view PR.

From my side checked with:

npm run lint
npm run typecheck
npm run prettier:check

[tatomyr]

Thank you @vladkens very much for handling all the comments! I'll review and merge your PR soon.

[tatomyr]

Looks good to me. Thank you again for your efforts @vladkens!
The changes will be available in the next release.