Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update react-tabs version 3 -> 4 to be compatible with react@18 #2401

Closed
wants to merge 1 commit into from

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented Sep 6, 2023

What/Why/How?

Support for React 18 has been recently added in Redoc. However, the react-tabs@3 only supports React 16 or 17. This causes issues when installing React 18 together with Redoc.

Reference

See the issue: Redocly/redocly-cli#1240

Tests

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

@tatomyr tatomyr self-assigned this Sep 6, 2023
@tatomyr tatomyr marked this pull request as ready for review September 7, 2023 12:14
@tatomyr tatomyr requested a review from a team as a code owner September 7, 2023 12:14
@tatomyr
Copy link
Contributor Author

tatomyr commented Sep 8, 2023

Closed in favor of this: #2404

@tatomyr tatomyr closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant