Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensuring that when there are multiple shards the keys pool is bellow request count(when defined) #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ensuring that when there are multiple shards the keys pool is bellow request count(when defined) #205

wants to merge 1 commit into from

Conversation

filipecosta90
Copy link
Collaborator

Fixes #204

@YaacovHazan
Copy link
Collaborator

@filipecosta90 thanks. The root cause is not the pool, but the fact that in case we are not pushing any request we are not disabling the events from the buuferevent
(bufferevent_disable(m_bev, EV_WRITE|EV_READ);)

@YaacovHazan YaacovHazan mentioned this pull request Jun 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaacovHazan YaacovHazan Awaiting requested review from YaacovHazan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

key pool can cause memtier to hang when there are multiple shards and request count is bellow pool size
2 participants
@filipecosta90 @YaacovHazan