clean CCVs first, CVs later

[evgeni]

this allows to remove more CVs, as removing CCVs might mark more CVs as unused

[evgeni]

@Rocco83 can you please have a look at this? That's splitting out the clean changes from #53

However, I am not 100% sure as your old code slightly contradicted the comments and I had to change it a bit.
Let me explain:

• cvs.sort_by! { |cv| cv["composite"] ? 0 : 1 } sorts the CCVs first, CVs last (as it sorts from 0 to 1)
• your old code had if cv["composite"] == true and firstccv == true which would fire on the very first CCV (so the first one we look at) and thus there is nothing to wait on
• I changed the logic to if not composite and firstcv, that is, clean all CCVs, when we find the first CV, wait for the created tasks.

I also dropped the exit from the error handling when the destroy fails, as I think its fine to continue here given https://projects.theforeman.org/issues/23458

[evgeni]

@gearboxscott also would love your opinion on this change (fresh minds and all)

[Rocco83]

I changed the logic to if not composite and firstcv, that is, clean all CCVs, when we find the first CV, wait for the created tasks.

It is a code refuse, because also in my comment there is

# Order the Content View to have before the non Composite Content View
# Needed to have delete proceeding in the correct order

Opposite of the current behavior.
I moved in a second time to CCV first (not CV as by comment).
Fun fact, this mess has been done to spot https://projects.theforeman.org/issues/23458.

Long story short, your code fix is correct 👍

I also dropped the exit from the error handling when the destroy fails, as I think its fine to continue here given https://projects.theforeman.org/issues/23458

👍