This repository has been archived by the owner on Dec 8, 2020. It is now read-only.
base64 password and query optimization for publish method #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 18, 2017 10:40
Added documentation line about base64 password encryption
changed ended time with started time for publish and task query Optimized search for get sync task started after last cv publish start time
|
Optimized query on sync task started after last cv publish. added filter for get only task that match repository id you are checking |
bandrea83
changed the title
|
ping @evgeni :) |
Rocco83
added a commit
to Rocco83/katello-cvmanager
that referenced
this pull request
May 3, 2018
…tellite#43 This fix override also PR RedHatSatellite#52, making it obsolete.
evgeni
suggested changes
May 3, 2018
| @@ -77,7 +77,7 @@ Example configuration for `cvmanager`: | |||
| - application1 | |||
|
|
|||
| * `user`: username of a Satellite 6 user to execute the actions with | |||
| * `pass`: password of the same user | |||
| * `pass`: password of the same user in base64 encryption (generate with 'echo -n "sat_password" | base64') | |||
| @@ -198,7 +201,7 @@ def clean() | |||
| end | |||
|
|
|||
| def checktask(task, last_date) | |||
| task_completed_at = Time.xmlschema(task['ended_at']) rescue Time.parse(task['ended_at']) | |||
| task_completed_at = Time.xmlschema(task['started_at']) rescue Time.parse(task['started_at']) | |||
There was a problem hiding this comment.
can you explain a bit more what is fixed here? I fear with that change we'll be missing the tasks that started before last_date but ended after it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code for manage base64 password encryption.
Updated documentation for base64 password encryption