Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jtesar/chapter1 cli install #7

Merged
merged 27 commits into from
Nov 13, 2023
Merged

Jtesar/chapter1 cli install #7

merged 27 commits into from
Nov 13, 2023

Conversation

jtesar-rh
Copy link
Collaborator

The section has been rewritten forn the Operator V2

Copy link

github-actions bot commented Nov 1, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-13 17:24 UTC

@rsriniva
Copy link
Contributor

rsriniva commented Nov 3, 2023

@jhurlocker and @strangiato - please review the CLI install steps and notes

modules/chapter1/pages/section3.adoc Show resolved Hide resolved
--

[#findchannel]
=== Finding Update Channels and Cluster Service Versions
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really need to teach people how to query the channels. It is more important to explain the point behind each channel and when to choose them.

modules/chapter1/pages/section3.adoc Outdated Show resolved Hide resolved
--

[#manual_approval]
=== Approving Installation Manualy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, useful content, but it needs to be talked about in the specific context of the RHODS subscription.

modules/chapter1/pages/section3.adoc Outdated Show resolved Hide resolved
modules/chapter1/pages/section3.adoc Outdated Show resolved Hide resolved
<1> The namespace to install the operator into.
<2> The update channel to install the operator from. To find all available channels see the the xref:section3.adoc#findchannel[Finding Update Channels and Cluster Service Versions] section.
<3> The Cluster Service Version (CSV) to install. To find all available CSVs for the selected channel see the the xref:section3.adoc#findchannel[Finding Update Channels and Cluster Service Versions] section.
<4> In case the *installPlanApproval* is set to *Manual*, approve the installation first to start it. Refer to the xref:section3.adoc#manual_approval[Approving Installation Manualy] section for more information.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where we probably want to get into a little bit more detail about install plan approvals. I don't think it is worth going into a ton of details about how manual approvals work but it might be nice to link to some content that goes over the topic in more detail.

modules/chapter1/pages/section3.adoc Outdated Show resolved Hide resolved
modules/chapter1/pages/section3.adoc Outdated Show resolved Hide resolved
modules/chapter1/pages/section3.adoc Outdated Show resolved Hide resolved
<1> Name of the subscription resource.
<2> Name of the namespace to create the subscription resource in.
<3> Update channel to install the operator from. For more information about finding available channels see the xref:section3.adoc#findchannel[Finding Update Channels] section.
<4> *installPlanApproval* attribute can be either *Automatic* or *Manual*. For more details about manual installation approval se the xref:section3.adoc#manual_approval[Approving Installation Manualy] section.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"se" to "see"

Copy link
Collaborator

@jramcast jramcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the CLI-based installation in the Base RHODS on AWS demo and it works well. This is good enough for the workshop IMO, so let's move forward and merge. Address pending comments from @strangiato before merging. If we need further refinements, we can create additional PRs, or even better, collect feedback from the workshop and apply that feedback later.

= Section 3
= Installation Using the Command Line Interface

This section covers installation of the *Red{nbsp}Hat Openshift Data Science* from the command line interface. Command line installation requires a bit more understanding of openshift resources than the web based installation hence before we get to the actual installation we will go over some theory related to the CLI-based operator installation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This section covers installation of the *Red{nbsp}Hat Openshift Data Science* from the command line interface. Command line installation requires a bit more understanding of openshift resources than the web based installation hence before we get to the actual installation we will go over some theory related to the CLI-based operator installation.
This section covers installation of the *Red{nbsp}Hat Openshift Data Science* from the command line interface. Command line installation requires a bit more understanding of OpenShift resources than the web based installation hence before we get to the actual installation we will go over some theory related to the CLI-based operator installation.

@jtesar-rh jtesar-rh merged commit a50d49d into main Nov 13, 2023
1 check passed
@jtesar-rh jtesar-rh deleted the jtesar/chapter1-cli-install branch November 13, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants