Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jtesar/chapter1 general installation #5

Merged
merged 18 commits into from
Nov 10, 2023

Conversation

jtesar-rh
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Nov 1, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-10 13:07 UTC

@rsriniva
Copy link
Contributor

rsriniva commented Nov 3, 2023

@jhurlocker and @strangiato - please review this short section

modules/chapter1/pages/section1.adoc Outdated Show resolved Hide resolved
modules/chapter1/pages/section1.adoc Outdated Show resolved Hide resolved
Copy link
Collaborator

@jramcast jramcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left a non-blocking comment. Please go ahead and merge.

NOTE: I also noticed that we are not using the new Red Hat Openshift.AI product name but IMO we can do that later, and run sed over all courses or something like that. At this point, I am bit confused by the naming, so I would wait until the terminology is a bit more stable.

modules/chapter1/pages/section1.adoc Outdated Show resolved Hide resolved
@jtesar-rh jtesar-rh merged commit a311d28 into main Nov 10, 2023
1 check passed
@jtesar-rh jtesar-rh deleted the jtesar/chapter1-general-installation branch November 10, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants