Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update(docs): TrustyAI, Component name, example CLI #47

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Update(docs): TrustyAI, Component name, example CLI #47

merged 1 commit into from
Mar 28, 2024

Conversation

zdtsw
Copy link
Contributor

@zdtsw zdtsw commented Mar 22, 2024

  • TrustyAI should not set to Managed
  • odh-dashboard is for upstream, in RHOAI it is dashboard
  • DSCI/DSC CR has default name, to simplify CLI
  • Remove "get" CLI which is not necessary for deletion

@zdtsw
Update(docs): TrustyAI, Component name, example CLI
46432d1 
- TrustyAI should not set to Managed
- odh-dashboard is for upstream, in RHOAI it is dashboard
- DSCI/DSC CR has default name, to simplify CLI
- Remove "get" CLI which is not necessary for deletion

Signed-off-by: Wen Zhou <[email protected]>
@rsriniva
Copy link
Contributor

Thank you for the PR @zdtsw ! I'll leave the PR open for 24 hrs and merge it tomorrow if you don't have more changes

@rsriniva rsriniva merged commit 8aa2534 into RedHatQuickCourses:main Mar 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsriniva rsriniva rsriniva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zdtsw @rsriniva