OSIDB-3454: Fix suggestions dropdown on component unmount #433
+111
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C-Valen
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSIDB-3454: Fix suggestions dropdown on component unmount
Checklist:
Changelog updatedSummary:
Refactor the DjangoQL textaea to its own component, that way the
v-iftriggers the mount/unmount hooks.Changed the
v-iftov-showso the djangoql completion cache is keptChanges:
[Replace with a detailed description of the changes made in this PR, including any new features, enhancements, bug fixes, or refactorings.]
Considerations:
Closes OSIDB-3454