Chore: Directory based components and widgets #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C-Valen
force-pushed
the
chore/directory-based-components-preparation
branch
2 times, most recently
from
93c3e35
to
3d03e7c
Compare
|
Update: Use named component index templates. |
MrMarble
reviewed
Sep 6, 2024
.eslintrc.json
Outdated
| @@ -76,7 +76,7 @@ | |||
| "vue/multi-word-component-names": [ | |||
| "error", | |||
| { | |||
| "ignores": ["Modal", "Tabs", "Toast", "Login", "Navbar", "Settings"] | |||
| "ignores": ["Modal", "Tabs", "Toast", "Login", "Navbar", "Settings", "index"] | |||
There was a problem hiding this comment.
Not really, it was for previous approach but is not required now.
C-Valen
force-pushed
the
chore/directory-based-components-preparation
branch
from
3d03e7c
to
bd230c7
Compare
C-Valen
force-pushed
the
chore/directory-based-components-preparation
branch
2 times, most recently
from
077d159
to
0a6235c
Compare
♻️ Use component directory names
C-Valen
force-pushed
the
chore/directory-based-components-preparation
branch
from
0a6235c
to
ab4acda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chore - Directory based components and widgets
Checklist:
Summary:
As discussed in internal team calls this PR converts
@/componentsand@/widgetsinto to directory based vue components.This allows to break down large components in smaller parts providing more flexibility and an easier maintainability, aiming to adopt an atomic component design pattern.
Changes:
@/componentsand@/widgets@/widgetsto/srcreplace aliaseson vite config to array formatWidgetTestViewConsiderations:
widgetsdirectory made sense to me to be relocated at./srcto be at same level asviewsandcomponents