remove mixin loop #743
Merged
remove mixin loop #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costaconrado
force-pushed
the
uat-environment
branch
from
64677ba
to
a59c2c7
Compare
osoukup
approved these changes
Sep 23, 2024
MrMarble
approved these changes
Sep 23, 2024
JakubFrejlach
approved these changes
Sep 23, 2024
costaconrado
force-pushed
the
uat-environment
branch
from
a59c2c7
to
bcf24cb
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a infinite recursion in save method when sync to bugzilla is disabled.
This commit db2cc6f introduced a infinite recursion in environments that don't sync to bugzilla, when validations were separated from BugzillaSyncMixin, was no need to bzsync method to skip mixins / call the next save method, making this infinite loop.
The way the 409 used to happen was by calling save method multiple times until the current save call have a different timestamp from the 1st save call, throwing the exception presented in https://github.com/RedHatProductSecurity/osidb/blob/master/osidb/mixins.py#L52
Closes OSIDB-3430.