-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split models #742
split models #742
Conversation
35637d4
to
a80707e
Compare
73ad9f3
to
1380cd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite big changes, but LGTM now. It seems that there is now empty dmodels
directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! Truly well done, this must have been such PITA to split out everything and constantly rebase. I two minor points, but nothing serious, will leave that up to you.
@jobselko when I hit |
Also git is not tracking directories on its own, just files so it should not be possible to have empty directory in the repository, it is however possible to have an seemingly empty leftover directory on your local machine with some hidden files or leftover pycache. |
The last wave of model split. It at the end renames the dmodels directory to models so it gets all automatically recognized by Django. I know it is huge but the thing is that the Affect and Flaw models are everywhere so it is as it is - hopefully going commit-wise can help understanding the changes. Most of the commits just mechanically repeat the same change over and over and it is at the end just moving the furniture around.
Closes OSIDB-378