Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split models #742

Merged
merged 16 commits into from
Oct 14, 2024
Merged

split models #742

merged 16 commits into from
Oct 14, 2024

Conversation

osoukup
Copy link
Contributor

@osoukup osoukup commented Sep 19, 2024

The last wave of model split. It at the end renames the dmodels directory to models so it gets all automatically recognized by Django. I know it is huge but the thing is that the Affect and Flaw models are everywhere so it is as it is - hopefully going commit-wise can help understanding the changes. Most of the commits just mechanically repeat the same change over and over and it is at the end just moving the furniture around.

Closes OSIDB-378

@osoukup osoukup self-assigned this Sep 19, 2024
@osoukup osoukup force-pushed the split-models branch 3 times, most recently from 35637d4 to a80707e Compare September 25, 2024 10:45
@osoukup osoukup force-pushed the split-models branch 5 times, most recently from 73ad9f3 to 1380cd8 Compare October 12, 2024 09:33
@osoukup osoukup marked this pull request as ready for review October 13, 2024 07:02
@osoukup osoukup requested a review from a team October 13, 2024 07:03
@osoukup osoukup added the technical For PRs that introduce changes not worthy of a CHANGELOG entry label Oct 13, 2024
Copy link
Contributor

@jobselko jobselko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite big changes, but LGTM now. It seems that there is now empty dmodels directory.

osidb/models/flaw/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@dmonzonis dmonzonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Copy link
Contributor

@JakubFrejlach JakubFrejlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Truly well done, this must have been such PITA to split out everything and constantly rebase. I two minor points, but nothing serious, will leave that up to you.

osidb/dmodels/affect.py Outdated Show resolved Hide resolved
apps/bbsync/query.py Outdated Show resolved Hide resolved
@osoukup
Copy link
Contributor Author

osoukup commented Oct 14, 2024

Quite big changes, but LGTM now. It seems that there is now empty dmodels directory.

@jobselko when I hit git ls-files | grep dmodels I get nothing so I do not think there are any dmodels left. You can also double check by looking at https://github.com/RedHatProductSecurity/osidb/tree/split-models/osidb

@JakubFrejlach
Copy link
Contributor

Quite big changes, but LGTM now. It seems that there is now empty dmodels directory.

@jobselko when I hit git ls-files | grep dmodels I get nothing so I do not think there are any dmodels left. You can also double check by looking at https://github.com/RedHatProductSecurity/osidb/tree/split-models/osidb

Also git is not tracking directories on its own, just files so it should not be possible to have empty directory in the repository, it is however possible to have an seemingly empty leftover directory on your local machine with some hidden files or leftover pycache.

@osoukup osoukup added this pull request to the merge queue Oct 14, 2024
Merged via the queue into master with commit 2624eb7 Oct 14, 2024
11 checks passed
@osoukup osoukup deleted the split-models branch October 14, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical For PRs that introduce changes not worthy of a CHANGELOG entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants