chore(RHINENG-6147): Paginated requests #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkholjuraev
force-pushed
the
paginated-requests
branch
from
eef6939 to
92b1664
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1163 +/- ##
==========================================
+ Coverage 63.60% 63.69% +0.09%
==========================================
Files 126 126
Lines 3154 3173 +19
Branches 817 822 +5
==========================================
+ Hits 2006 2021 +15
- Misses 1148 1152 +4 ☔ View full report in Codecov by Sentry. |
|
/retest |
mkholjuraev
force-pushed
the
paginated-requests
branch
from
0c30dbb to
e74861f
Compare
gkarat
reviewed
Mar 5, 2024
gkarat
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
OK, it feels like RedHatInsights/frontend-components#1954 hasn't been released yet for some reason. Let's merge this PR if you feel ready.
|
@gkarat thank you for the review! |
|
🎉 This PR is included in version 1.67.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Associated Jira ticket: # RHINENG-6147
Selection of all items was using API calls with limit=-1 across all pages where bulk selection is enabled. This PR converts it to use paginated requests.
remediation issues fetching also fetching 1000 items per request, now it is reduced to 100.
Unassigning/assigning templates had another usage of limit=-1. Now they are converted to use paginated requests.
How to test the PR
Please include steps to test your PR.
Before the change
After the change
Resolves: RHINENG
Dependent work link
Checklist: