Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add learning resources creator #54

Merged
merged 145 commits into from
Jul 11, 2024
Merged

Add learning resources creator #54

merged 145 commits into from
Jul 11, 2024

Conversation

randomnetcat
Copy link
Contributor

@randomnetcat randomnetcat commented Jun 17, 2024 •
edited
Loading

@randomnetcat randomnetcat added the enhancement New feature or request label Jun 17, 2024
@randomnetcat randomnetcat self-assigned this Jun 17, 2024
@randomnetcat randomnetcat mentioned this pull request Jun 20, 2024
Merged
@randomnetcat randomnetcat requested a review from a team June 25, 2024 14:21
@randomnetcat randomnetcat marked this pull request as ready for review June 26, 2024 14:38
Hyperkid123
Hyperkid123 reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS will need some work:

screenshot-stage foo redhat com_1337-2024 06 27-10_02_37

I also got some strange full page reload while trying to access the next step:

screencast-stage.foo.redhat.com_1337-2024.06.27-10_07_39.webm

src/App.tsx Outdated Show resolved Hide resolved
src/Creator.tsx Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/Creator.tsx Outdated Show resolved Hide resolved
src/Creator.tsx Outdated Show resolved Hide resolved
src/components/creator/CreatorInputs.tsx Outdated Show resolved Hide resolved
src/components/creator/CreatorInputs.tsx Outdated Show resolved Hide resolved
src/components/creator/CreatorInputs.tsx Outdated Show resolved Hide resolved
src/components/creator/CreatorInputs.tsx Outdated Show resolved Hide resolved
src/components/creator/CreatorInputs.tsx Outdated Show resolved Hide resolved
@randomnetcat randomnetcat mentioned this pull request Jun 27, 2024
Merged
@randomnetcat
Copy link
Contributor Author

randomnetcat commented Jun 27, 2024 •
edited
Loading

Oh, and overall:

Sorry! Yes, I didn't put in time to make the layout pretty because I wasn't sure if this code would survive at all.

Just fixed the navigation issue (I hope).

@Hyperkid123
Copy link
Contributor

Sorry! Yes, I didn't put in time to make the layout pretty because I wasn't sure if this code would survive at all.

it will survive 🙂 . Especially the CSS.

@randomnetcat randomnetcat requested a review from Hyperkid123 July 1, 2024 19:09
randomnetcat added 19 commits July 5, 2024 11:02
@randomnetcat
Temporarily replace app with Creator component
afa1f24 
I know this will have to be fixed at some point, but this seems like the easiest way to get started.
@randomnetcat
Add basic type selection
0ba4429
@randomnetcat
Add named types for item kinds
a7bf3e5
@randomnetcat
Use Patternfly FormGroup for radio buttons
5b95f92
@randomnetcat
Add form with bundle input
74e857d
@randomnetcat
Add title input
757c816
@randomnetcat
Add description input
2a41447
@randomnetcat
Unify input prop types
f7a863f
@randomnetcat
Use a loop for common item inputs
809cb75
@randomnetcat
Add placeholders
9c226a8
@randomnetcat
Add URL input when type is documentation
71230c4
@randomnetcat
Add separate ItemFormContainer
bc454d9
@randomnetcat
Add duration input when type is quickstart
b844b30
@randomnetcat
Add required indicators to field groups
2095e93
@randomnetcat
Move type field to own component
d2c20cb
@randomnetcat
Add labeled FormGroup around type input
3f6e3c4
@randomnetcat
Add labels to DurationInput
f486bde
@randomnetcat
Use InputProps for all applicable components
41f21c4
@randomnetcat
Use grid to divide screen into columns
895f89c
@Hyperkid123 Hyperkid123 requested a review from a team July 10, 2024 06:55
Hyperkid123
Hyperkid123 reviewed Jul 10, 2024
View reviewed changes
Copy link
Contributor

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good. I think the logic is almost complete. 👍

src/components/creator/CreatorWizard.tsx Outdated Show resolved Hide resolved
src/components/creator/schema.ts Outdated Show resolved Hide resolved
src/Creator.tsx Show resolved Hide resolved
Hyperkid123
Hyperkid123 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I think we are good on the functionality. We will have to work on the visual side as well. But This PR is large enough. It can be done that in a follow-up.

Just FYI, I'll squash the commits Its a bit too much 😉

@Hyperkid123 Hyperkid123 merged commit 360ef47 into master Jul 11, 2024
4 checks passed
@Hyperkid123 Hyperkid123 deleted the creator branch July 11, 2024 07:03
@randomnetcat
Copy link
Contributor Author

What UI changes are you looking for?

@Hyperkid123
Copy link
Contributor

@randomnetcat to exactly match the mocks provided by UX.

@randomnetcat randomnetcat mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyperkid123 Hyperkid123 Hyperkid123 approved these changes

Assignees

@randomnetcat randomnetcat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randomnetcat @Hyperkid123