chore(RHINENG-10336): Update cypress code-cov package (#514)

* chore(RHINENG-10336): Update cypress code-cov package * Fix issues with tests There were a couple of issues with App Zero State tests that have been resolved in this commit. --------- Co-authored-by: Michael Johnson <[email protected]>
RedHatInsights · Oct 8, 2024 · 5e52f86 · 5e52f86
1 parent f8fb218
commit 5e52f86
Show file tree

Hide file tree

Showing 9 changed files with 33 additions and 36 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -88,7 +88,7 @@
     "@babel/preset-env": "7.15.4",
     "@babel/preset-flow": "7.14.5",
     "@babel/preset-react": "7.14.5",
-    "@cypress/code-coverage": "^3.10.0",
+    "@cypress/code-coverage": "^3.12.37",
     "@cypress/react18": "^2.0.1",
     "@formatjs/cli": "4.2.33",
     "@redhat-cloud-services/frontend-components-config": "^6.0.13",

diff --git a/pr_check.sh b/pr_check.sh
@@ -4,6 +4,7 @@ export COMPONENT="insights-dashboard-frontend"
 export IMAGE="quay.io/cloudservices/$COMPONENT"
 export WORKSPACE=${WORKSPACE:-$APP_ROOT}  # if running in jenkins, use the build's workspace
 export APP_ROOT=$(pwd)
+export NODE_BUILD_VERSION=18
 cat /etc/redhat-release
 COMMON_BUILDER=https://raw.githubusercontent.com/RedHatInsights/insights-frontend-builder-common/master
 

diff --git a/src/Messages.js b/src/Messages.js
@@ -450,11 +450,7 @@ export default defineMessages({
         description: 'Learn more about Insights',
         defaultMessage: 'Learn more about Insights'
     },
-    insightsDescription: {
-        id: 'insightsDescription',
-        description: 'insights Description',
-        defaultMessage: 'Single, consistent management solution across on-premise, hybrid cloud, and public cloud. Included with Red Hat Enterprise Linux subscription. Single, consistent management solution across on-premise, hybrid cloud, and public cloud.'
-    },
+    insightsDescription: 'Single, consistent management solution across on-premise, hybrid cloud, and public cloud. Included with Red Hat Enterprise Linux subscription. Single, consistent management solution across on-premise, hybrid cloud, and public cloud.',
     contactsales: {
         id: 'contactsales',
         description: 'Contact sales',

diff --git a/src/PresentationalComponents/ZeroState/AppZeroState.js b/src/PresentationalComponents/ZeroState/AppZeroState.js
@@ -5,7 +5,7 @@ import ZeroStateFooter from './ZeroStateFooter';
 import propTypes from 'prop-types';
 import { IntlProvider } from '@redhat-cloud-services/frontend-components-translations';
 import { useAxiosWithPlatformInterceptors } from '@redhat-cloud-services/frontend-components-utilities/interceptors';
-import zeroStateAppList from './zeroStateConstants';
+import { createAppNamesList } from './zeroStateHelpers';
 
 const standardApiReq = '/api/inventory/v1/hosts?page=1&per_page=1';
 
@@ -75,7 +75,7 @@ const AppZeroState = ({
 
 export default AppZeroState;
 
-const appNames = Object.keys(zeroStateAppList).map(key => key.split('_')[0]);
+const appNames = createAppNamesList();
 
 AppZeroState.propTypes = {
     children: propTypes.any,

diff --git a/src/PresentationalComponents/ZeroState/AppZeroState.test.js b/src/PresentationalComponents/ZeroState/AppZeroState.test.js
@@ -4,7 +4,7 @@ import React from 'react';
 import AppZeroState from './AppZeroState';
 import { MemoryRouter, Route, Routes } from 'react-router-dom';
 import { useAxiosWithPlatformInterceptors } from '@redhat-cloud-services/frontend-components-utilities/interceptors';
-import zeroStateAppList from './zeroStateConstants';
+import { createAppNamesList } from './zeroStateHelpers';
 
 jest.mock('@redhat-cloud-services/frontend-components-utilities/interceptors', () => ({
     __esModule: true,
@@ -14,7 +14,7 @@ jest.mock('@redhat-cloud-services/frontend-components-utilities/interceptors', (
     }))
 }));
 
-const appNames = Object.keys(zeroStateAppList).map(key => key.split('_')[0]);
+const appNames = createAppNamesList();
 const randomApp = appNames[Math.floor(Math.random() * appNames.length)];
 
 describe('AppZeroState component', () => {

diff --git a/src/PresentationalComponents/ZeroState/ZeroStateBanner.js b/src/PresentationalComponents/ZeroState/ZeroStateBanner.js
@@ -22,15 +22,15 @@ import zeroStateConstants from './zeroStateConstants';
 
 const ZeroStateBanner = ({
     appName,
-    description = zeroStateConstants[`${appName.toUpperCase()}_ZERO_STATE`].header.description,
-    commands = zeroStateConstants[`${appName.toUpperCase()}_ZERO_STATE`].header.commands,
-    bulletPoints = zeroStateConstants[`${appName.toUpperCase()}_ZERO_STATE`].header.bulletPoints,
     customInstructions,
     customButton,
     customText,
     customTitle,
     appId
 }) => {
+    const description = zeroStateConstants[`${appName.toUpperCase()}_ZERO_STATE`].header.description;
+    const commands = zeroStateConstants[`${appName.toUpperCase()}_ZERO_STATE`].header.commands;
+    const bulletPoints = zeroStateConstants[`${appName.toUpperCase()}_ZERO_STATE`].header.bulletPoints;
     const intl = useIntl();
     const { hideGlobalFilter } = useChrome();
 

diff --git a/src/PresentationalComponents/ZeroState/zeroStateConstants.js b/src/PresentationalComponents/ZeroState/zeroStateConstants.js
@@ -157,7 +157,8 @@ const INSIGHTS_ZERO_STATE = {
         ],
         bulletPoints: ['What problems do we solve', 'What solution do we provide']
     },
-    otherApps: {}
+    otherApps: [],
+    documentation: []
 };
 
 const CONTENT_MANAGEMENT_ZERO_STATE = {

diff --git a/src/PresentationalComponents/ZeroState/zeroStateHelpers.js b/src/PresentationalComponents/ZeroState/zeroStateHelpers.js
@@ -0,0 +1,5 @@
+import zeroStateAppList from './zeroStateConstants';
+
+export const createAppNamesList = () => {
+    return Object.keys(zeroStateAppList).map(key => key.replace('_ZERO_STATE', ''));
+};