fix ansible bundle trial redirects #2987
Merged
+154
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
himdel
reviewed
Jan 3, 2025
src/hooks/useTrialRedirect.ts
Outdated
| import { ChromeUser } from '@redhat-cloud-services/types'; | ||
| import { isAnsibleTrialFlagActive } from '../utils/isAnsibleTrialFlagActive'; | ||
|
|
||
| const ignoredPaths = ['/ansible/trial/*']; |
There was a problem hiding this comment.
Is the path correct? (and on line 16)
Shouldn't it be /ansible/ansible-dashboard/trial/*?
(Also /ansible/ansible-dashboard/trial itself.)
Definitely |
|
/retest |
Hyperkid123
force-pushed
the
ansible-trial
branch
from
9e7ea26 to
1e569e9
Compare
|
OK I've updated the trial routes. |
|
OK. I've updated the routes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/RHCLOUD-26705
Adds back check that redirects users to specific pages if they are not entitled to the current route.
@himdel can you please verify the route rule? Or do we know who knows to which routes the redirect should apply?