Merge pull request #2896 from jschuler/icon-spacing

Remove unnecessary icon margins if no icon present
RedHatInsights · Jul 19, 2024 · 5ab9ad3 · 5ab9ad3
2 parents a545c27 + a6dde4b
commit 5ab9ad3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 24 deletions.
diff --git a/src/components/Navigation/ChromeNavGroup.tsx b/src/components/Navigation/ChromeNavGroup.tsx
@@ -14,9 +14,11 @@ const ChromeNavGroup = ({ navItems, isHidden, icon, title }: ChromeNavGroupProps
 
   const groupTitle = (
     <div>
-      <Icon size="sm" className="pf-v5-u-mr-sm" isInline>
-        {icon && sectionTitleMapper[icon]}
-      </Icon>
+      {icon && (
+        <Icon size="sm" className="pf-v5-u-mr-sm" isInline>
+          {sectionTitleMapper[icon]}
+        </Icon>
+      )}
       {title}
     </div>
   );

diff --git a/src/components/Navigation/__snapshots__/ChromeNavGroup.test.js.snap b/src/components/Navigation/__snapshots__/ChromeNavGroup.test.js.snap
@@ -13,13 +13,6 @@ exports[`ChromeNavGroup should render nav item group 1`] = `
       id="Foo"
     >
       <div>
-        <span
-          class="pf-v5-c-icon pf-m-inline pf-m-sm pf-v5-u-mr-sm"
-        >
-          <span
-            class="pf-v5-c-icon__content"
-          />
-        </span>
         Foo
       </div>
     </h2>
@@ -85,13 +78,6 @@ exports[`ChromeNavGroup should render nav item group with items 1`] = `
       id="Foo"
     >
       <div>
-        <span
-          class="pf-v5-c-icon pf-m-inline pf-m-sm pf-v5-u-mr-sm"
-        >
-          <span
-            class="pf-v5-c-icon__content"
-          />
-        </span>
         Foo
       </div>
     </h2>

diff --git a/src/components/Navigation/__snapshots__/ChromeNavItemFactory.test.js.snap b/src/components/Navigation/__snapshots__/ChromeNavItemFactory.test.js.snap
@@ -80,13 +80,6 @@ exports[`ChromeNavItemFactory should render chrome group nav item 1`] = `
       id="group"
     >
       <div>
-        <span
-          class="pf-v5-c-icon pf-m-inline pf-m-sm pf-v5-u-mr-sm"
-        >
-          <span
-            class="pf-v5-c-icon__content"
-          />
-        </span>
         group
       </div>
     </h2>
-Original file line number
+Diff line change
@@ Expand Up @@
           id="group"
         >
           <div>
-            <span
-              class="pf-v5-c-icon pf-m-inline pf-m-sm pf-v5-u-mr-sm"
-            >
-              <span
-                class="pf-v5-c-icon__content"
-              />
-            </span>
             group
           </div>
         </h2>
@@ Expand Down @@