Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RHINENG-8385): Unblock opening menu by toggle click #2094

Merged

Conversation

LightOfHeaven1994
Copy link
Contributor

@LightOfHeaven1994 LightOfHeaven1994 commented Oct 30, 2024

This is going to help with preventing opening menu when toggle is clicked even for the first time. We need to consider it as we are clicking inside and do nothing

@mkholjuraev mkholjuraev requested a review from a team October 30, 2024 12:06
@gkarat gkarat added the bug Something isn't working label Oct 31, 2024
Copy link
Contributor

@gkarat gkarat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @LightOfHeaven1994

@LightOfHeaven1994 LightOfHeaven1994 merged commit e66918a into RedHatInsights:master Oct 31, 2024
2 checks passed
@Hyperkid123 Hyperkid123 added the release Once merged it will trigger bugfix release label Nov 1, 2024
@nacho-bot
Copy link
Collaborator

                      :soon::shipit::octocat:
     :bug:Shipit Squirrel has this release bugfix surrounded, be ready for a new version:beetle:

@nacho-bot
Copy link
Collaborator

     🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱

                The release is available on:

         :package:@redhat-cloud-services/frontend-components/v/4.2.22📦

             :boom:This feature is brought to you by probot🚀

@nacho-bot nacho-bot added the released Pr has been released label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release Once merged it will trigger bugfix release released Pr has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants