Allow spdy to be used as webpack dev server. #2071
Conversation
Hyperkid123
added
release minor
Hyperkid123
force-pushed
the
enable-spdy-devserver-config
branch
from
9eef74d to
1a33d4b
Compare
| @@ -2,7 +2,7 @@ import { LogType, fecLogger } from '@redhat-cloud-services/frontend-components-c | |||
| import { Compiler, WebpackPluginInstance } from 'webpack'; | |||
| import { CommonConfigOptions } from './createConfig'; | |||
|
|
|||
| const { SourceMapDevToolPlugin } = require('webpack'); | |||
| import { SourceMapDevToolPlugin } from 'webpack'; | |||
There was a problem hiding this comment.
The constructor below was still raising an error when starting webpack. Changing this import to just import webpack form 'webpack' and the constructor below to new webpack.SourceMapDevToolPlugin( seemed to solve the issues.
There was a problem hiding this comment.
OK let me change it.
There was a problem hiding this comment.
LGTM! I only had to change the Sourcemap thingy, maybe that needs some attention still, but I tested Compliance with the _unstableSpdy option and everything is zooooomin, aka it's fast, so fast! Thank you for looking into it @Hyperkid123!
Hyperkid123
force-pushed
the
enable-spdy-devserver-config
branch
from
1a33d4b to
9efefcc
Compare
|
:soon::shipit::octocat: |
|
🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱 The release is available on: :package:@redhat-cloud-services/frontend-components-config/v/6.3.0📦 :boom:This feature is brought to you by probot🚀 |
Changes
_unstableSpdyoption from fec.config.js to enable spdy as a dev server