Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(downloadFile): Use 'csv' value as a default format #2046

Merged
merged 1 commit into from
Aug 12, 2024
Merged

fix(downloadFile): Use 'csv' value as a default format #2046

merged 1 commit into from
Aug 12, 2024

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented Aug 9, 2024

No jira.

@gkarat gkarat added the bug Something isn't working label Aug 9, 2024
@gkarat gkarat self-assigned this Aug 9, 2024
@gkarat gkarat added the utils update to utils package label Aug 9, 2024
@gkarat gkarat requested review from Hyperkid123 and a team August 9, 2024 12:13
bastilian
bastilian reviewed Aug 9, 2024
View reviewed changes
packages/utils/src/helpers/helpers.ts
@@ -11,7 +11,7 @@ export function mergeArraysByKey(arrays: Record<string, unknown>[][], key = 'id'
return Object.values(mergedObject);
}

export function downloadFile(data: unknown, filename = `${new Date().toISOString()}`, format = CSV_TYPE) {
export function downloadFile(data: unknown, filename = `${new Date().toISOString()}`, format = 'csv') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;) https://github.com/RedHatInsights/frontend-components/blob/master/packages/utils/src/helpers/helpers.test.ts#L58

@Hyperkid123 Hyperkid123 added the release Once merged it will trigger bugfix release label Aug 12, 2024
@gkarat gkarat merged commit 1db3145 into RedHatInsights:master Aug 12, 2024
4 checks passed
@gkarat gkarat deleted the download-file-fix branch August 12, 2024 08:23
@Hyperkid123 Hyperkid123 added release Once merged it will trigger bugfix release and removed release Once merged it will trigger bugfix release labels Aug 12, 2024
@nacho-bot
Copy link
Collaborator

                      :soon::shipit::octocat:
     :bug:Shipit Squirrel has this release bugfix surrounded, be ready for a new version:beetle:

@nacho-bot
Copy link
Collaborator

     🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱

                The release is available on:

        :package:@redhat-cloud-services/frontend-components-utilities/v/4.0.15📦

             :boom:This feature is brought to you by probot🚀

@nacho-bot nacho-bot added the released Pr has been released label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastilian bastilian bastilian left review comments

@Hyperkid123 Hyperkid123 Hyperkid123 approved these changes

Assignees

@gkarat gkarat

Labels
bug Something isn't working release Once merged it will trigger bugfix release released Pr has been released utils update to utils package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gkarat @nacho-bot @bastilian @Hyperkid123