-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Jest test wrapper component created, CypressTestUtils folder relocated #2039
Conversation
@Fewwy I am tagging you as you were the author of CypressTestUtils. @gkarat This is the continuation of our discussion in the PR for vulnerability. |
@Hyperkid123 @gkarat PTAL, I forgot about this PR. Now, it has all the necessary changes. |
</IntlProvider> | ||
); | ||
}; | ||
const TestWrapper = (children, routerProps = { initialEntries: ['/'] }, componentPath, store = mockStore()) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the props should be wrapped in an object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @mkholjuraev
:soon::shipit::octocat: |
🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱 The release is available on: :package:@redhat-cloud-services/frontend-components-utilities/v/4.0.16📦 :boom:This feature is brought to you by probot🚀 |
This PR is intended to share our TestWrapper component that is used to render React components in Jest tests. I have also relocated the CypressTestUtils into the new TestUtils folder which is supposed to hold all test related utils. I made sure exports are fixed after relocation.