Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Patternfly dynamic-modules.json where possible #2030

Merged
merged 10 commits into from
Jul 8, 2024
Merged

Use Patternfly dynamic-modules.json where possible #2030

merged 10 commits into from
Jul 8, 2024

Conversation

randomnetcat
Copy link
Contributor

@randomnetcat randomnetcat commented Jul 3, 2024 •
edited
Loading

Per RHCLOUD-32457.

I have checked that it builds within this repository, but had trouble convincing another repository to link it in.

@randomnetcat randomnetcat requested a review from a team July 3, 2024 21:59
@randomnetcat
Copy link
Contributor Author

Ah, tests are failing due to the Patternfly updates. Oops (sorry, I did forget to run those locally). I'll look into that tomorrow.

@randomnetcat
Copy link
Contributor Author

Now fixed.

Hyperkid123
Hyperkid123 reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the guess-module.js and guess-module.d.ts into the .gitignore file.

@Hyperkid123 Hyperkid123 added the release Once merged it will trigger bugfix release label Jul 8, 2024
@randomnetcat
Copy link
Contributor Author

Fixed, sorry. Renamed that file at the end and forgot to update the gitignore.

@Hyperkid123 Hyperkid123 merged commit b1f5bb5 into master Jul 8, 2024
2 checks passed
@Hyperkid123 Hyperkid123 deleted the module-map branch July 8, 2024 12:51
@nacho-bot
Copy link
Collaborator

                      :soon::shipit::octocat:
     :bug:Shipit Squirrel has this release bugfix surrounded, be ready for a new version:beetle:

@nacho-bot
Copy link
Collaborator

     🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱

                The release is available on:

         :package:@redhat-cloud-services/tsc-transform-imports/v/1.0.15📦

             :boom:This feature is brought to you by probot🚀

@nacho-bot nacho-bot added the released Pr has been released label Jul 8, 2024
@nacho-bot
Copy link
Collaborator

     🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱

                The release is available on:

         :package:@redhat-cloud-services/frontend-components/v/4.2.13📦

             :boom:This feature is brought to you by probot🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyperkid123 Hyperkid123 Hyperkid123 approved these changes

Assignees
No one assigned
Labels
release Once merged it will trigger bugfix release released Pr has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@randomnetcat @nacho-bot @Hyperkid123