Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @redhat-cloud-services/rbac-client to 2.0.3 #2020

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Bump @redhat-cloud-services/rbac-client to 2.0.3 #2020

merged 1 commit into from
Jun 26, 2024

Conversation

ezr-ondrej
Copy link
Member

Update rbac-client so we stop pulling old axios client.

This pulls mostly RedHatInsights/javascript-clients#261

@ezr-ondrej
Copy link
Member Author

@RedHatInsights/platform-experience could you take a look? I dunno how to work with monorepos, happy to adjust this, but bumping this will IMO solve most repos axios vulnerabilities ;)

Hyperkid123
Hyperkid123 reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be problematic as TS change on FEC side, can mean a requirement for a major version upgrade on the consumer size.

Can we loosen the version of the dependency? To both v1 and v2? Or we will have to release a major version of the affected packages.

@ezr-ondrej
Copy link
Member Author

Sure. Loose as this looks good?

@Hyperkid123
Copy link
Contributor

I'd say we want to keep the ^1.0.111 just to make sure. 2.x is OK for now. I the next major release (its coming) we will just use the 2.x

@ezr-ondrej
Copy link
Member Author

Gotcha, make sense. Done ^1.0.111 || 2.x

@Hyperkid123 Hyperkid123 added the release Once merged it will trigger bugfix release label Jun 26, 2024
@Hyperkid123 Hyperkid123 merged commit decf42a into RedHatInsights:master Jun 26, 2024
2 checks passed
@nacho-bot
Copy link
Collaborator

                      :soon::shipit::octocat:
     :bug:Shipit Squirrel has this release bugfix surrounded, be ready for a new version:beetle:

@ezr-ondrej ezr-ondrej deleted the bump_rbac_client branch June 26, 2024 09:15
@nacho-bot
Copy link
Collaborator

     🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱

                The release is available on:

          :package:@redhat-cloud-services/types/v/1.0.11📦

             :boom:This feature is brought to you by probot🚀

@nacho-bot
Copy link
Collaborator

     🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱

                The release is available on:

        :package:@redhat-cloud-services/frontend-components-utilities/v/4.0.12📦

             :boom:This feature is brought to you by probot🚀

@nacho-bot nacho-bot added the released Pr has been released label Jun 26, 2024
@ezr-ondrej
Copy link
Member Author

Right, I've missed the direct dependency: #2021 😮‍💨

@ezr-ondrej
Copy link
Member Author

I missed two, not one: #2022 😮‍💨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyperkid123 Hyperkid123 Hyperkid123 approved these changes

Assignees
No one assigned
Labels
release Once merged it will trigger bugfix release released Pr has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezr-ondrej @Hyperkid123 @nacho-bot