fix(config): Remove obsolete fec config bits #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastilian
force-pushed
the
remove_fecconfig_clutter
branch
from
62b49da to
c447203
Compare
AsToNlele
approved these changes
Jun 14, 2024
Hyperkid123
approved these changes
Jun 14, 2024
|
:soon::shipit::octocat: |
|
🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱 The release is available on: :package:@redhat-cloud-services/frontend-components-config-utilities/v/3.0.7📦 :boom:This feature is brought to you by probot🚀 |
|
🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱 The release is available on: :package:@redhat-cloud-services/frontend-components-config/v/6.0.16📦 :boom:This feature is brought to you by probot🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
redux-promise-middlewarefrom being shared, as this might cause issues when incompatible versions of(react-)reduxandredux-promise-middleware.It also removed the stubbing of
redux-loggerin prod. We should not need to do this, asredux-loggershould not be imported in a prod asset in the first place. If it is, the apps should properly setup entry points for dev and prod.