fix(fec): Make bundle analyzer optional feature #2001
Conversation
bastilian
changed the title
| @@ -18,7 +18,7 @@ const { config: webpackConfig, plugins } = config({ | |||
| plugins.push(...commonPlugins, ...externalPlugins); | |||
|
|
|||
| const start = (env: { analyze?: string }): Configuration => { | |||
| if (env && env.analyze === 'true') { | |||
| if (BundleAnalyzerPlugin && env && env.analyze === 'true') { | |||
There was a problem hiding this comment.
I think we can just kick it out entirely. Plugins can be extended from within fec.config.js anyway. Can you add a deprecation warning to this condition? So we can remove it in next major release?
|
@Hyperkid123 Since we intend to remove it, I removed it again from the dependencies and just wrapped the config in a |
|
:soon::shipit::octocat: |
|
🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱 The release is available on: :package:@redhat-cloud-services/frontend-components-config/v/6.0.13📦 :boom:This feature is brought to you by probot🚀 |
The webpack prod config requires webpack-bundle-analyzer, this makes it optional and adds webpack-bundle-analyzer as a peer dependency in case apps do want to enable bundle analysing.