fix(BulkSelect): RHINENG-9831 - Don't override passed in children #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsonm325
approved these changes
May 1, 2024
adonispuente
approved these changes
May 1, 2024
|
@Hyperkid123 I merged this thinking it would trigger a release. Would it be possible to trigger a release for this? Pwetty please puppy eyes. It would fix a few bugs we found in apps that use the toggleProps.children. |
Hyperkid123
added
release
|
:soon::shipit::octocat: |
|
🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱 The release is available on: :package:@redhat-cloud-services/frontend-components/v/4.2.8📦 :boom:This feature is brought to you by probot🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through the change to PF5 components a bug was introduced to the BulkSelect in the frontend components that overrides children passed in via the toggleProps. Since a number of applications use this to show a loading icon or the number of items selected, etc, we should not be overriding these when passed in.