[RHCLOUD-30109] Batch updates for last-visited-pages #1959
Conversation
BlakeHolifield
force-pushed
the
RHCLOUD-30109
branch
5 times, most recently
from
146892f to
1a9584e
Compare
| console.error('Unable to update last visited pages!', error); | ||
| } | ||
| // Save state from localStorage on an interval | ||
| setInterval(async () => { |
There was a problem hiding this comment.
You have to clear the interval in the useEffect cleanup phase. Currently this can cause memory leaks.
| } | ||
| // Save state from localStorage on an interval | ||
| setInterval(async () => { | ||
| await updateMostRecentPages(); |
There was a problem hiding this comment.
No reason to await this call. We are not working with the return value.
| return () => { | ||
| titleObserver?.disconnect(); | ||
| postDataDebounced?.cancel(); | ||
| document.removeEventListener('visibilitychange', handleVisibilityChange); |
There was a problem hiding this comment.
We should also clear the inactiveTimeout.current here if it exists.
| const lastVisited = localStorage.getItem(LAST_VISITED_FLAG); | ||
| if (lastVisited) { | ||
| const lastVisitedLocal = localStorage.getItem(LAST_VISITED_FLAG); | ||
| const getInitialPages = async () => { |
There was a problem hiding this comment.
This function should be defined out of the effect.
BlakeHolifield
force-pushed
the
RHCLOUD-30109
branch
2 times, most recently
from
c365daa to
4907546
Compare
packages/chrome/package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@redhat-cloud-services/chrome", | |||
| "version": "1.0.7", | |||
| "version": "1.0.8", | |||
There was a problem hiding this comment.
This is automated no need to bump the version manually.
BlakeHolifield
force-pushed
the
RHCLOUD-30109
branch
from
4907546 to
4e192cc
Compare
|
:soon::shipit::octocat: |
|
🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱 The release is available on: :package:@redhat-cloud-services/chrome/v/1.0.8📦 :boom:This feature is brought to you by probot🚀 |
Migrates the
useLastVisitedPageshook to only push batch updates to the APIhiddenfor 20 seconds, the user's last 10 pages from localStorage will be saved in the DB