-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ibutsu reporter #1939
Ibutsu reporter #1939
Conversation
reporter: path.resolve(__dirname, "../../node_modules/mocha-ibutsu-reporter"), | ||
reporterOptions: { | ||
project: "frontend-components", | ||
component: "some-component", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hyperkid123 can we choose a more meaningful name for our component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess since this is a monorepo this is less important... but it'd be nice to indicate this is related to RedHatInsights
or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need a component value that aligns with our QE test data aggregation. I'm guessing it will need to match the component values available in Ibutsu.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@catastrophe-brandon do you know which component values are available? From the reporter doc it seemed like we could pick whatever value we want - but I see what you mean with aligning with QE test data aggregation.
Ref: https://github.com/ibutsu/mocha-ibutsu-reporter#merging-files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@florkbr I'll defer to @catastrophe-brandon here. No clue what values are required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the time being, please set the project to "insights-qe" and the component to "frontend-components". We'll have to follow-up with another PR anyways, so if anything changes in the meantime, we'll update the config.
bd54f7a
to
fce52c0
Compare
@mrpetrbartos done |
Jira: https://issues.redhat.com/browse/RHCLOUD-27038
cc @catastrophe-brandon