Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ibutsu reporter #1939

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Conversation

Hyperkid123
Copy link
Contributor

@Hyperkid123 Hyperkid123 commented Nov 15, 2023

@Hyperkid123 Hyperkid123 marked this pull request as ready for review November 15, 2023 15:23
@Hyperkid123 Hyperkid123 requested a review from a team November 15, 2023 15:24
reporter: path.resolve(__dirname, "../../node_modules/mocha-ibutsu-reporter"),
reporterOptions: {
project: "frontend-components",
component: "some-component",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hyperkid123 can we choose a more meaningful name for our component?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess since this is a monorepo this is less important... but it'd be nice to indicate this is related to RedHatInsights or something

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a component value that aligns with our QE test data aggregation. I'm guessing it will need to match the component values available in Ibutsu.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@catastrophe-brandon do you know which component values are available? From the reporter doc it seemed like we could pick whatever value we want - but I see what you mean with aligning with QE test data aggregation.

Ref: https://github.com/ibutsu/mocha-ibutsu-reporter#merging-files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@florkbr I'll defer to @catastrophe-brandon here. No clue what values are required.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the time being, please set the project to "insights-qe" and the component to "frontend-components". We'll have to follow-up with another PR anyways, so if anything changes in the meantime, we'll update the config.

@Hyperkid123
Copy link
Contributor Author

@mrpetrbartos done

@Hyperkid123 Hyperkid123 merged commit 203d7f3 into RedHatInsights:master Nov 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants