Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LongTextTooltip component #1935

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Remove LongTextTooltip component #1935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea6a13f
Remove LongTextTooltip component
fhlavac Nov 9, 2023
6a264fc
Update to latest component-groups version
fhlavac Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
157 changes: 88 additions & 69 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion packages/components/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ transform: (importName) =>`@redhat-cloud-services/frontend-components/esm/${FECM
* [emptyTable](doc/emptyTable.md)
* [input](doc/input.md)
* [dropdown](doc/dropdown.md)
* [longTextTooltip](doc/longTextTooltip.md)
* [spinner](doc/spinner.md)
* [ansible](doc/ansible.md)
* [filters](doc/filters.md)
Expand Down
32 changes: 0 additions & 32 deletions packages/components/doc/longTextTooltip.md
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"dependencies": {
"@redhat-cloud-services/frontend-components-utilities": "^4.0.0",
"@redhat-cloud-services/types": "^0.0.24",
"@patternfly/react-component-groups": "^1.2.1",
"@patternfly/react-component-groups": "^5.0.0-prerelease.5",
"@scalprum/core": "^0.5.4",
"@scalprum/react-core": "^0.5.4",
"sanitize-html": "^2.7.2"
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/DownloadButton/__snapshots__/DownloadButton.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ exports[`DownloadButton component API clicking should open dropdown 1`] = `
data-popper-escaped="true"
data-popper-placement="bottom-start"
data-popper-reference-hidden="true"
style="position: absolute; left: 0px; top: 0px; z-index: 9999; min-width: 0px; transform: translate(0px, 0px);"
style="position: absolute; left: 0px; top: 0px; z-index: 9999; opacity: 1; transition: opacity 0ms cubic-bezier(.54, 1.5, .38, 1.11); min-width: 0px; transform: translate(0px, 0px);"
>
<div
class="pf-v5-c-menu__content"
Expand Down
10 changes: 0 additions & 10 deletions packages/components/src/LongTextTooltip/LongTextTooltip.tsx
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions packages/components/src/LongTextTooltip/index.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/components/src/PrimaryToolbar/__snapshots__/Actions.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ exports[`Actions - component API should update open 1`] = `
data-ouia-component-id="Actions"
data-ouia-component-type="PF5/Dropdown"
data-ouia-safe="true"
style="position: absolute; left: 0px; top: 0px; z-index: 9999; min-width: 0px;"
style="position: absolute; left: 0px; top: 0px; z-index: 9999; opacity: 0; transition: opacity 0ms cubic-bezier(.54, 1.5, .38, 1.11); min-width: 0px;"
>
<div
class="pf-v5-c-menu__content"
Expand Down
8 changes: 8 additions & 0 deletions packages/components/src/TagModal/__snapshots__/TagModal.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,9 @@ exports[`Two tables Should render modal with disabled button 1`] = `
>
<Tabs
activeKey={0}
backScrollAriaLabel="Scroll back"
component="div"
forwardScrollAriaLabel="Scroll forward"
hasNoBorderBottom={false}
isBox={false}
isFilled={false}
Expand Down Expand Up @@ -437,7 +439,9 @@ exports[`Two tables should render modal with enabled button 1`] = `
>
<Tabs
activeKey={0}
backScrollAriaLabel="Scroll back"
component="div"
forwardScrollAriaLabel="Scroll forward"
hasNoBorderBottom={false}
isBox={false}
isFilled={false}
Expand Down Expand Up @@ -562,7 +566,9 @@ exports[`Two tables should render two tables 1`] = `
>
<Tabs
activeKey={0}
backScrollAriaLabel="Scroll back"
component="div"
forwardScrollAriaLabel="Scroll forward"
hasNoBorderBottom={false}
isBox={false}
isFilled={false}
Expand Down Expand Up @@ -680,7 +686,9 @@ exports[`Two tables should render two tables in loading state 1`] = `
>
<Tabs
activeKey={0}
backScrollAriaLabel="Scroll back"
component="div"
forwardScrollAriaLabel="Scroll forward"
hasNoBorderBottom={false}
isBox={false}
isFilled={false}
Expand Down
1 change: 0 additions & 1 deletion packages/components/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// eslint-disable-next-line @typescript-eslint/no-unused-vars
import * as t from '@redhat-cloud-services/types'; // required to get the API. We can't use simple import due to tree shaking
export * from './LongTextTooltip';
export * from './Section';
export * from './Ansible';
export * from './Main';
Expand Down
Loading