fix(config-utils): Also check env for BETA to choose deployment #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastilian
force-pushed
the
fed_mods_proxy_improvements
branch
from
6c9fb13 to
ea4d62d
Compare
bastilian
force-pushed
the
fed_mods_proxy_improvements
branch
from
ea4d62d to
eac5903
Compare
Hyperkid123
reviewed
Nov 27, 2023
packages/config/src/lib/index.ts
Outdated
| @@ -61,7 +61,8 @@ const createFecConfig = ( | |||
| fecLogger(LogType.info, 'no git branch detected, using main for webpack "main" config.'); | |||
| gitBranch = 'main'; | |||
| } | |||
| const appDeployment = configurations.deployment || (isProd && betaBranches.includes(gitBranch) ? 'beta/apps' : 'apps'); | |||
| const appDeployment = | |||
| configurations.deployment || ((isProd && betaBranches.includes(gitBranch)) || process.env.BETA === 'true' ? 'beta/apps' : 'apps'); | |||
There was a problem hiding this comment.
@bastilian nice catch. This condition needs a little bit of love in general.
Can you add a check for the configurations.deployment as well? Just to make sure we don't run into any edge cases.
const appDeployment = typeof configurations.deployment === 'string' ? configurations.deployment : ...
Hyperkid123
added
bug
bastilian
force-pushed
the
fed_mods_proxy_improvements
branch
from
eac5903 to
888ca49
Compare
Hyperkid123
approved these changes
Nov 28, 2023
|
:soon::shipit::octocat: |
|
🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱 The release is available on: :package:@redhat-cloud-services/frontend-components-config/v/6.0.6📦 :boom:This feature is brought to you by probot🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds another check that will help prevent apps failing to deploy containers properly for preview environments, since we now set wether or not it is preview via the env variable and not the branch names.