Skip to content

Commit

Permalink
Merge pull request #2134 from Hyperkid123/local-dev-config-substitution
Browse files Browse the repository at this point in the history
feat(config-utils): add navigation bundle interceptor
  • Loading branch information
Hyperkid123 authored Dec 16, 2024
2 parents a9bb60d + 17cd50b commit 8ba3472
Show file tree
Hide file tree
Showing 5 changed files with 924 additions and 1 deletion.
30 changes: 30 additions & 0 deletions navnotes.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# Nav notes updates

## Current attributes

### appId

For some reason nav items in expandable item require `appId` to show. This should not be required a it needs to b fixed in chrome: https://github.com/RedHatInsights/insights-chrome/blob/master/src/components/Navigation/ChromeNavExpandable.tsx#L7

### id

Id should be mandatory attribute of any non segment nav item


## Missing FEO nav attributes

### bundleSegmentRef

Required to match nav item to bundle segment from frontend crd.

Nav items should inherit this from the bundle segment they come from.

Should be needed only by the first level.

### segmentRef

Same as `bundleSegmentRef`, but for global segments.

### frontendRef

Required to match nav item in bundle to current app
9 changes: 8 additions & 1 deletion packages/config-utils/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,13 @@
"options": {
"command": "git push --tags"
}
}
},
"test:unit": {
"executor": "@nx/jest:jest",
"outputs": ["{workspaceRoot}/coverage/{projectRoot}"],
"options": {
"jestConfig": "packages/config-utils/jest.config.ts"
}
},
}
}
Loading

0 comments on commit 8ba3472

Please sign in to comment.