-
Notifications
You must be signed in to change notification settings - Fork 102
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #2134 from Hyperkid123/local-dev-config-substitution
feat(config-utils): add navigation bundle interceptor
- Loading branch information
Showing
5 changed files
with
924 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# Nav notes updates | ||
|
||
## Current attributes | ||
|
||
### appId | ||
|
||
For some reason nav items in expandable item require `appId` to show. This should not be required a it needs to b fixed in chrome: https://github.com/RedHatInsights/insights-chrome/blob/master/src/components/Navigation/ChromeNavExpandable.tsx#L7 | ||
|
||
### id | ||
|
||
Id should be mandatory attribute of any non segment nav item | ||
|
||
|
||
## Missing FEO nav attributes | ||
|
||
### bundleSegmentRef | ||
|
||
Required to match nav item to bundle segment from frontend crd. | ||
|
||
Nav items should inherit this from the bundle segment they come from. | ||
|
||
Should be needed only by the first level. | ||
|
||
### segmentRef | ||
|
||
Same as `bundleSegmentRef`, but for global segments. | ||
|
||
### frontendRef | ||
|
||
Required to match nav item in bundle to current app |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.