fix: Remove defaullt value for https while creating a config

RedHatInsights · Oct 9, 2024 · 1de0831 · 1de0831
1 parent fc6ec6e
commit 1de0831
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/config/src/lib/config.test.js b/packages/config/src/lib/config.test.js
@@ -44,7 +44,7 @@ describe('should create dummy config with no options', () => {
       static: {
         directory: '/dist',
       },
-      server: 'https',
+      server: 'http',
       host: '0.0.0.0',
       port: 8002,
       hot: false,

diff --git a/packages/config/src/lib/createConfig.ts b/packages/config/src/lib/createConfig.ts
@@ -62,7 +62,7 @@ export const createConfig = ({
   publicPath,
   appEntry,
   rootFolder,
-  https = true,
+  https,
   mode,
   appName,
   useFileHash = true,
@@ -274,7 +274,7 @@ export const createConfig = ({
         directory: `${rootFolder || ''}/dist`,
       },
       port: devServerPort,
-      server: _unstableSpdy ? 'spdy' : https ? 'https' : 'http',
+      server: _unstableSpdy ? 'spdy' : https || Boolean(useProxy) ? 'https' : 'http',
       host: '0.0.0.0', // This shares on local network. Needed for docker.host.internal
       hot: internalHotReload, // Use livereload instead of HMR which is spotty with federated modules
       liveReload: !internalHotReload,