already registered emails bug fixed #214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarryMotaLavigne
approved these changes
Mar 27, 2020
|
Hi! Can you please push this change to pip? I'm facing the same problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In such case that user email is unique and normal user registering is available: If a user tries to social sign-in with a registered email, it will end up with db error saying the email is already exists!
For example assume this scenario:
1- user register normally (using normal register form) with his/her gmail.
2- the user tries to login by google with the same gmail address.
as I mentioned above,
convert-tokenrequest will response with 500 error because of db error.I fixed this problem by catching this error in
oauth2_grantsfile (SocialTokenGrant.validate_token_requestmethod).