Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: syncing translations for alternative download #370

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

deltork
Copy link
Collaborator

@deltork deltork commented Nov 8, 2024

PR Goal?

Syncing translations for alternative download

Fixes?

#369

Feedback sought?

sanity check

Priority?

Tests added?

How to test?

Upload a single file-format to the editor, modify the translations and export alternative format

Confidence?

high

Version change?

bug fix

@deltork deltork requested a review from joanise November 8, 2024 16:47
Copy link

semanticdiff-com bot commented Nov 8, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  packages/studio-web/src/app/shared/download/download.service.ts  0% smaller
  packages/web-component/project.json  0% smaller

Copy link
Contributor

github-actions bot commented Nov 8, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-11-08 17:18 UTC

Copy link
Member

@joanise joanise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

So simple.

@deltork deltork merged commit 408fb1d into main Nov 8, 2024
2 checks passed
@deltork deltork deleted the dev.del/fix-sync-translation-for-download branch November 8, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants