Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teardown first #7448

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Teardown first #7448

wants to merge 3 commits into from

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Feb 28, 2024

This addresses #7443

It doesn't however revert the changes made during 8 alpha that affect operators like first, take, some, et al. Which we'll want to do to make sure we're at parity with the web platform, and with the duals of this type. (In short: other implementations of take will not finalize the source before emitting the value, only before it completes)

Other things:

  • While working on this I discovered some age-old bad logic in the WebSocketSubject that would have it try to send an unsubscribe message to the socket server when the socket server disconnected or errored.

@benlesh benlesh added the AGENDA ITEM Flagged for discussion at core team meetings label Feb 28, 2024
Copy link

nx-cloud bot commented Feb 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9a05f17. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AGENDA ITEM Flagged for discussion at core team meetings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant